[Message Prev][Message Next][Thread Prev][Thread Next][Message Index][Thread Index]

Re: unified-patch18-6

 

Peter Bystrom wrote:

I'm sorry, but I fail to get this, it works perfectly well with my screen at 24bpp.
What is the output of xdpyinfo?

This is the significant difference between 24 and 32 bbp mode on my server:

$ diff /tmp/xdpyinfo.24bpp.out /tmp/xdpyinfo.32bpp.out
1c1
< name of display:    :1.0
---
> name of display:    :0.0
12c12
<     depth 24, bits_per_pixel 24, scanline_pad 32
---
>     depth 24, bits_per_pixel 32, scanline_pad 32

My guess is that you are running X in 32bpp mode.  You specify the mode when you start up X:

  X -bpp 24 :1.0

Your server might revert to 32bpp mode when you don't specify it.

Attached is an image of rdesktop running on a server which is truly in 24bpp mode.
 

 

below is an attached XFconfig file from my computer...
 

if I set my defaultdepth to 24, which states that I have a depth of 24-bits, I can either start rdesktop as it is, or use the -D 24 switch.

the tdfx driver can't use a depth of 32, but the bits are to my knowledge handeld equally as in a depth of 24, so the code should work there as well.

handling is the same; in our code a depth of 24 and 32 is equally fast.

what's the problem?
 
 
 

regards,

peter
 
 

Section "ServerLayout"
        Identifier "XFree86 Configured"
        Screen      0  "Screen0" 0 0
        InputDevice    "Mouse0" "CorePointer"
        InputDevice    "Keyboard0" "CoreKeyboard"
EndSection
 

Section "Files"
        FontPath "unix/:7100"
        FontPath "tcp/localhost:7101"
EndSection

Section "Module"
        Load  "GLcore"
        Load  "dbe"
        Load  "dri"
        Load  "extmod"
        Load  "glx"
        Load  "pex5"
        Load  "record"
        Load  "xie"
        Load  "v4l"
EndSection

Section "InputDevice"
        Identifier  "Keyboard0"
        Driver      "keyboard"
        Option      "XkbLayout" "se"
EndSection

Section "InputDevice"
        Identifier  "Mouse0"
        Driver      "mouse"
        Option      "Device" "/dev/mouse"
        Option      "Protocol" "MouseManPlusPS/2"
        Option      "Emulate3Buttons" "off"
        Option      "ZAxisMapping" "4 5"
EndSection

Section "Monitor"
        Identifier "Nokia 447Xpr"
        VendorName "Unknown"
        ModelName  "Unknown"
        HorizSync 30 - 96
        VertRefresh 50 - 150
EndSection

Section "Device"
        Identifier "3Dfx Interactive, Inc.|Voodoo 3"
        Driver "tdfx"
        BoardName "Unknown"
EndSection

Section "Screen"
        Identifier "Screen0"
        Device "3Dfx Interactive, Inc.|Voodoo 3"
        Monitor "Nokia 447Xpr"
        DefaultDepth 16
        Subsection "Display"
                Depth 8
                Modes "1024x768"
        EndSubsection
        Subsection "Display"
                Depth 16
                Modes "1024x768"
        EndSubsection
        Subsection "Display"
                Depth 24
                Modes "1024x768"
        EndSubSection
EndSection

Section "DRI"
        Mode 0666
EndSection
 
 

Sveinn Sveinsson wrote:

Hi,

patch 18-6 looks very good, except that it doesn't work with X in 24bpp mode, but that doesn't concern me much.  It used to work using my patch to the 16bit patch, so this functionality could easily be restored if somebody needs it.

Attached is a minor change I made to tcp.c

Regards,
Svenni. 








-- 
Sveinn Sveinsson                      | mailto:svenni@strengur.is
Strengur ltd Computer Consultants     | mailto:ssveinss@informix.com
Ármúla 7                              | Phone: +354-550-9000
IS-108 Reykjavik                      | Fax: +354-550-9010
Iceland

 

diff -Naur rdesktop-patched/tcp.c rdesktop-patched2/tcp.c
--- rdesktop-patched/tcp.c      Tue Jan  9 09:28:28 2001
+++ rdesktop-patched2/tcp.c     Tue Jan  9 09:29:45 2001
@@ -120,7 +120,7 @@
              in.end += rcvd;
              length -= rcvd;
            }
-         else if (uisocket != -1 && FD_ISSET (uisocket, &rfds))
+         if (uisocket != -1 && FD_ISSET (uisocket, &rfds))
            {
              ui_process_events ();
            }







-- 
Sveinn Sveinsson                      | mailto:svenni@strengur.is
Strengur ltd Computer Consultants     | mailto:ssveinss@informix.com
Ármúla 7                              | Phone: +354-550-9000
IS-108 Reykjavik                      | Fax: +354-550-9010
Iceland

 

JPEG image


name of display:    :1.0
version number:    11.0
vendor string:    The XFree86 Project, Inc
vendor release number:    335
maximum request size:  4194300 bytes
motion buffer size:  256
bitmap unit, bit order, padding:    32, LSBFirst, 32
image byte order:    LSBFirst
number of supported pixmap formats:    2
supported pixmap formats:
    depth 1, bits_per_pixel 1, scanline_pad 32
    depth 24, bits_per_pixel 24, scanline_pad 32
keycode range:    minimum 8, maximum 134
focus:  window 0x200000e, revert to Parent
number of extensions:    19
    BIG-REQUESTS
    DOUBLE-BUFFER
    DPMS
    LBX
    MIT-SCREEN-SAVER
    MIT-SHM
    MIT-SUNDRY-NONSTANDARD
    RECORD
    SECURITY
    SHAPE
    SYNC
    XC-APPGROUP
    XC-MISC
    XFree86-DGA
    XFree86-Misc
    XFree86-VidModeExtension
    XInputExtension
    XKEYBOARD
    XTEST
default screen number:    0
number of screens:    1

screen #0:
  dimensions:    1600x1200 pixels (542x406 millimeters)
  resolution:    75x75 dots per inch
  depths (1):    24
  root window id:    0x26
  depth of root window:    24 planes
  number of colormaps:    minimum 1, maximum 1
  default colormap:    0x23
  default number of colormap cells:    256
  preallocated pixels:    black 0, white 16777215
  options:    backing-store YES, save-unders YES
  largest cursor:    64x64
  current input event mask:    0x58003d
    KeyPressMask             ButtonPressMask          ButtonReleaseMask        
    EnterWindowMask          LeaveWindowMask          SubstructureNotifyMask   
    SubstructureRedirectMask PropertyChangeMask       
  number of visuals:    1
  default visual id:  0x22
  visual:
    visual id:    0x22
    class:    TrueColor
    depth:    24 planes
    available colormap entries:    256 per subfield
    red, green, blue masks:    0xff0000, 0xff00, 0xff
    significant bits in color specification:    8 bits



name of display:    :0.0
version number:    11.0
vendor string:    The XFree86 Project, Inc
vendor release number:    335
maximum request size:  4194300 bytes
motion buffer size:  256
bitmap unit, bit order, padding:    32, LSBFirst, 32
image byte order:    LSBFirst
number of supported pixmap formats:    2
supported pixmap formats:
    depth 1, bits_per_pixel 1, scanline_pad 32
    depth 24, bits_per_pixel 32, scanline_pad 32
keycode range:    minimum 8, maximum 134
focus:  window 0x3c00008, revert to PointerRoot
number of extensions:    19
    BIG-REQUESTS
    DOUBLE-BUFFER
    DPMS
    LBX
    MIT-SCREEN-SAVER
    MIT-SHM
    MIT-SUNDRY-NONSTANDARD
    RECORD
    SECURITY
    SHAPE
    SYNC
    XC-APPGROUP
    XC-MISC
    XFree86-DGA
    XFree86-Misc
    XFree86-VidModeExtension
    XInputExtension
    XKEYBOARD
    XTEST
default screen number:    0
number of screens:    1

screen #0:
  dimensions:    1600x1200 pixels (542x406 millimeters)
  resolution:    75x75 dots per inch
  depths (1):    24
  root window id:    0x26
  depth of root window:    24 planes
  number of colormaps:    minimum 1, maximum 1
  default colormap:    0x23
  default number of colormap cells:    256
  preallocated pixels:    black 0, white 16777215
  options:    backing-store YES, save-unders YES
  largest cursor:    64x64
  current input event mask:    0xf84033
    KeyPressMask             KeyReleaseMask           EnterWindowMask          
    LeaveWindowMask          KeymapStateMask          SubstructureNotifyMask   
    SubstructureRedirectMask FocusChangeMask          PropertyChangeMask       
    ColormapChangeMask       
  number of visuals:    1
  default visual id:  0x22
  visual:
    visual id:    0x22
    class:    TrueColor
    depth:    24 planes
    available colormap entries:    256 per subfield
    red, green, blue masks:    0xff0000, 0xff00, 0xff
    significant bits in color specification:    8 bits